-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert smapp changes #518
Revert smapp changes #518
Conversation
I can't seem to re-break my machine to test, if someone doesn't mind doing the tests we did before in a VM, that would be super helpful. https://github.com/macadmins/nudge/releases/tag/v1.1.13.81506 I think we have 3 cases to test:
|
I wonder if there is a way to just return the code vs deleting it. I still don't understand why Apple is using this logic automatically when it's not supposed to trigger unless explicitly set |
What would the advantage of returning the code be vs removing it for now? It would be trivial to add back later. |
I more so just don't understand the behavior that's happening. |
Perhaps the course of action could be:
At the end of the day, if this doesn't fix the issue with the SMAppService bug, then we shouldn't bother reverting at all. |
In my first test going 1.1.11 --> 1.1.12 --> 1.1.13.81506 (gutted SMAS), it doesn’t fix the problem. The legacy LA still refuses to load. Even after reboots and even opening Nudge manually. So it looks like going with either of the two 1.1.13 pre-releases (updated SMAS or gutted SMAS) will still require admins to take some manual action to remediate. (Since it sounds like us deciding to do it for them by running So admins who have already deployed 1.1.12 and are experiencing this problem will have to handle running |
Given this doesn't actually fix anything and would perhaps make it even more confusing adding/removing the pref, Let's kill this PR. |
This reverts the SMAppService changes until we can fully test all the edge cases and Apple perhaps makes SMAppService an actual functional way of managing LaunchAgents.